Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Denoiser doesn't use RT preset with OpenImageDenoise #22

Closed
caiowakamatsu opened this issue Jul 28, 2021 · 1 comment
Closed

Denoiser doesn't use RT preset with OpenImageDenoise #22

caiowakamatsu opened this issue Jul 28, 2021 · 1 comment
Labels
enhancement New feature or request invalid This doesn't seem right

Comments

@caiowakamatsu
Copy link

In OidnBinaryDenoiser, the command line arguments don't use the RT preset that OIDN supplies in the native API. The RT preset allows you to use a different denoising method that's better suited for ray / path tracing.

Possible solutions: Create a small wrapper of OIDN for chunky, to allow for you to set the denoising filter.

@leMaik leMaik added the enhancement New feature or request label Oct 1, 2021
@leMaik
Copy link
Member

leMaik commented Aug 28, 2022

The default filter type in the denoiser binary is already RT: https://github.com/OpenImageDenoise/oidn/blob/master/apps/oidnDenoise.cpp#L81

@leMaik leMaik closed this as completed Aug 28, 2022
@leMaik leMaik added the invalid This doesn't seem right label Aug 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request invalid This doesn't seem right
Projects
None yet
Development

No branches or pull requests

2 participants