Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for custom block models #1332

Draft
wants to merge 42 commits into
base: master
Choose a base branch
from

Conversation

leMaik
Copy link
Member

@leMaik leMaik commented Jul 3, 2022

This PR adds support for custom block models. It can (and currently is hard-coded to do so) also replace Chunky's built-in models by models generated from the minecraft jar file.

default_2022-07-03_20-30-16-100 denoised

Caveats:

  • Does not support tint colors (yet, we'll have to change the way Chunky handles tint colors)
  • Redstone and some other blocks are not rendered
  • Redstone tinting isn't supported yet
  • Water is not yet rendered and might show question marks
  • Lava might be broken
  • Randomized block variants always use the first block variant
  • Doesn't support resource pack directories (unzipped resource packs) yet
  • Azalea leaves somehow are not transparent
  • Entity blocks don't show up due to entityLoadingPreferences causing them not to load by default
  • You need to manually re-apply the resourcepacks once after launch (and then reload the world to update the map view)
  • Replace TintedQuad and use the tints array instead (as in hard-coded models)
  • JsonModel and MultipartJsonModel shouldn't be Blocks
  • Fix eg. minecraft:pitcher_plant

To get the latest build of this PR, follow this guide: https://github.com/leMaik/chunky-pr-as-update-site
Due to a bug, you currently have to open the resource pack dialog and apply the resourcepacks after launching this Chunky build. Then it will load the models. Reload the world if you only see purple blocks.

Fixes #88 and fixes #426.

@jackjt8
Copy link
Member

jackjt8 commented Oct 10, 2022

Outside of models larger than a block and cube-like models not rendering:
image
image

It does appear that everything else shows up to some extent. Not so much the right model, but the vanilla ones.

Otherwise, loading the whole of Greenfield indicates that there is an issue that slows down the loading of the BVH and spams the debug console with a lot of stuff.

chunky_log.txt

@Zhou-Shilin
Copy link

What's the progress?

@leMaik
Copy link
Member Author

leMaik commented Feb 12, 2024

@Zhou-Shilin Needs a rebase and is not ready yet. There is a checklist above.

leMaik and others added 24 commits February 18, 2024 20:37
…ert large blocks to block entities automatically.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Question and possible feature] Using textures specified from the block model json Support mod blocks
5 participants