Fix to load dependent assembly from specified path #45
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Small fix to enable loading dependent assemblies from specified path
Description
Fixed ArgumentOutOfRangeException from .Substring() by checking length parameter
- in case when we are running .IndexOf(',') on already stripped from commas "NameOfYourAddInDll"
Added check to skip searching for the assembly if assembly with specified name is already loaded
- in case when AssemblyResolve tries to find "NameOfYourAddInDll.resources" and ".resources" is stripped from the name
Fixed return value from ShowDialog() to return true after closing with Ok button
Removed confusing (duplicated) ShowWarning() when the dependent assembly can't be loaded
Declarations
Check these if you believe they are true
*.resx
filesReviewers
@chuongmep
FYIs