Support logstash 5 #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 4 commits
February 2, 2018 16:38
They are inherited from the AWS Mixin
chupakabr
reviewed
Feb 8, 2018
| @@ -45,8 +45,6 @@ class LogStash::Outputs::Firehose < LogStash::Outputs::Base | |||
|
|
|||
| # make properties visible for tests | |||
| attr_accessor :stream | |||
| attr_accessor :access_key_id | |||
There was a problem hiding this comment.
how do you specify access and secret keys to your stream from now on?
There was a problem hiding this comment.
In the same way. By including the AWS Mixin these configuration options are already available.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This brings support for Logstash 5, but also allows a future PR (logstash-plugins/logstash-mixin-aws#27) to work. It's not necessary to specify access_key_id and secret_key_id parameters as they are inherited from the aws-mixin