Fix UEFI VM options #525
Open
Fix UEFI VM options #525
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ckoehne
reviewed
Sep 8, 2023
- When configuring UEFI, don't overwrite previous options. - When configuring UEFI, don't repeat -H. - Move -w from UEFI options to default options.
|
This PR is essential to make Linux VMs work in FreeBSD 13.2-RELEASE-p3 with edk2-bhyve-g202308. Without this, my Linux VMs would fail to finish booting entirely. |
|
fwiw, I've applied this patch manually and my linux VM still refuses to start. The configuration is: (edited out disk and networking) when trying to start it I get: |
|
Probably the same problem here (1.5.0/uefi/13.2-RELEASE-p8). It worked until recent update to 13.2-RELEASE-p8. Now machine starts for a moment then exits with error 4 or 134. |
ke5C2Fin
reviewed
May 5, 2024
| @@ -109,7 +109,7 @@ vm::run(){ | |||
| fi | |||
|
|
|||
| # default bhyve options | |||
| _opts="-AHP" | |||
| _opts="-AHPw" | |||
|
|
|||
| # ignore access to unimplemented Model Specific Registers? | |||
| config::yesno "ignore_msr" && _opts="${_opts}w" | |||
There was a problem hiding this comment.
If we add -w on line 112, then adding it on line 115 does nothing.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently,
vm::runinitializes_optsto-AHP, then, in the UEFI case callsvm::uefiwhich, instead of appending to_opts, sets it to-Hwl bootrom,.... This means UEFI VMs are started without-A, which was never a good idea but which causes them to fail to boot with recent versions ofedk2-bhyve(see https://bugs.freebsd.org/273560).The main purpose of this PR is to change
vm::uefito append to_optsso-Ais not lost and UEFI VMs boot correctly.In addition, it moves the
-woption from UEFI-only to default, and deduplicates the-Hoption.