-
-
Notifications
You must be signed in to change notification settings - Fork 173
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix UEFI VM options #525
base: master
Are you sure you want to change the base?
Fix UEFI VM options #525
Conversation
- When configuring UEFI, don't overwrite previous options. - When configuring UEFI, don't repeat -H. - Move -w from UEFI options to default options.
This PR is essential to make Linux VMs work in FreeBSD 13.2-RELEASE-p3 with edk2-bhyve-g202308. Without this, my Linux VMs would fail to finish booting entirely. |
fwiw, I've applied this patch manually and my linux VM still refuses to start. The configuration is:
(edited out disk and networking) when trying to start it I get:
|
Probably the same problem here (1.5.0/uefi/13.2-RELEASE-p8). It worked until recent update to 13.2-RELEASE-p8. Now machine starts for a moment then exits with error 4 or 134. |
@@ -109,7 +109,7 @@ vm::run(){ | |||
fi | |||
|
|||
# default bhyve options | |||
_opts="-AHP" | |||
_opts="-AHPw" | |||
|
|||
# ignore access to unimplemented Model Specific Registers? | |||
config::yesno "ignore_msr" && _opts="${_opts}w" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If we add -w
on line 112, then adding it on line 115 does nothing.
Currently,
vm::run
initializes_opts
to-AHP
, then, in the UEFI case callsvm::uefi
which, instead of appending to_opts
, sets it to-Hwl bootrom,...
. This means UEFI VMs are started without-A
, which was never a good idea but which causes them to fail to boot with recent versions ofedk2-bhyve
(see https://bugs.freebsd.org/273560).The main purpose of this PR is to change
vm::uefi
to append to_opts
so-A
is not lost and UEFI VMs boot correctly.In addition, it moves the
-w
option from UEFI-only to default, and deduplicates the-H
option.