Skip to content
This repository has been archived by the owner on Feb 23, 2024. It is now read-only.

fix(server): save campaign - scenario link at scenario execution end #1037

Merged
merged 2 commits into from
Jul 25, 2023

Conversation

rbenyoussef
Copy link
Collaborator

Issue Number

fixes #

Describe the changes you've made

Describe if there is any unusual behaviour of your code

Additional context

Test plan

Checklist

  • Refer to issue(s) the PR solves
  • New java code is covered by tests
  • Add screenshots or gifs of the new behavior, if applicable.
  • All new and existing tests pass
  • No git conflict

@rbenyoussef rbenyoussef force-pushed the fix/ui_bug branch 4 times, most recently from a307923 to eb73cce Compare May 12, 2023 09:16
@rbenyoussef rbenyoussef marked this pull request as ready for review May 12, 2023 09:33
KarimGl
KarimGl previously approved these changes Jun 6, 2023
@boddissattva
Copy link
Member

When i have a campaign with parallel execution checked, i have error like :

11:34:59.269 [campaign-executor14] WARN o.h.e.jdbc.spi.SqlExceptionHelper - SQL Error: 5, SQLState: null
11:34:59.269 [campaign-executor14] ERROR o.h.e.jdbc.spi.SqlExceptionHelper - [SQLITE_BUSY] The database file is locked (database is locked)

And the campaign report does not reference all the scenario executions.

Bug case :
Create a scenario which sleep for a while with two extra copies.
Create campaign with these threes with parallel execution checked.
Execute the campaign.

@boddissattva boddissattva self-requested a review July 6, 2023 09:43
Copy link
Member

@boddissattva boddissattva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Campaign parallel execution to fix.

@boddissattva boddissattva self-requested a review July 25, 2023 08:02
@bessonm bessonm merged commit d2e9062 into master Jul 25, 2023
3 checks passed
@bessonm bessonm deleted the fix/ui_bug branch July 25, 2023 13:51
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants