This repository has been archived by the owner on Feb 23, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
57568a4
to
a85ac37
Compare
a85ac37
to
8876b15
Compare
Codecov Report
@@ Coverage Diff @@
## master #584 +/- ##
============================================
- Coverage 74.02% 73.11% -0.91%
- Complexity 3405 3410 +5
============================================
Files 629 634 +5
Lines 14746 14888 +142
Branches 864 859 -5
============================================
- Hits 10915 10886 -29
- Misses 3386 3560 +174
+ Partials 445 442 -3
Continue to review full report at Codecov.
|
boddissattva
reviewed
Oct 8, 2021
...e/src/test/java/com/chutneytesting/engine/domain/execution/engine/ScenarioExecutionTest.java
Outdated
Show resolved
Hide resolved
boddissattva
reviewed
Oct 8, 2021
task-impl/src/main/java/com/chutneytesting/task/TaskValidatorsUtils.java
Outdated
Show resolved
Hide resolved
boddissattva
reviewed
Oct 8, 2021
task-impl/src/main/java/com/chutneytesting/task/TaskValidatorsUtils.java
Outdated
Show resolved
Hide resolved
boddissattva
reviewed
Oct 8, 2021
task-impl/src/main/java/com/chutneytesting/task/TaskValidatorsUtils.java
Outdated
Show resolved
Hide resolved
boddissattva
reviewed
Oct 8, 2021
task-spi/src/main/java/com/chutneytesting/task/spi/time/Duration.java
Outdated
Show resolved
Hide resolved
boddissattva
reviewed
Oct 8, 2021
task-impl/src/main/java/com/chutneytesting/task/TaskValidatorsUtils.java
Outdated
Show resolved
Hide resolved
boddissattva
reviewed
Oct 8, 2021
task-impl/src/main/java/com/chutneytesting/task/TaskValidatorsUtils.java
Outdated
Show resolved
Hide resolved
boddissattva
reviewed
Oct 8, 2021
task-impl/src/main/java/com/chutneytesting/task/TaskValidatorsUtils.java
Outdated
Show resolved
Hide resolved
boddissattva
reviewed
Oct 8, 2021
task-impl/src/main/java/com/chutneytesting/task/TaskValidatorsUtils.java
Outdated
Show resolved
Hide resolved
bessonm
reviewed
Oct 8, 2021
task-spi/src/main/java/com/chutneytesting/task/spi/validation/Validator.java
Show resolved
Hide resolved
task-impl/src/main/java/com/chutneytesting/task/TaskValidatorsUtils.java
Outdated
Show resolved
Hide resolved
task-impl/src/main/java/com/chutneytesting/task/TaskValidatorsUtils.java
Outdated
Show resolved
Hide resolved
task-impl/src/main/java/com/chutneytesting/task/mongo/MongoUpdateTask.java
Outdated
Show resolved
Hide resolved
task-impl/src/main/java/com/chutneytesting/task/amqp/AmqpBasicPublishTask.java
Show resolved
Hide resolved
task-impl/src/main/java/com/chutneytesting/task/amqp/AmqpCleanQueuesTask.java
Show resolved
Hide resolved
task-impl/src/main/java/com/chutneytesting/task/amqp/AmqpCreateBoundTemporaryQueueTask.java
Show resolved
Hide resolved
boddissattva
reviewed
Oct 8, 2021
task-impl/src/main/java/com/chutneytesting/task/TaskValidatorsUtils.java
Outdated
Show resolved
Hide resolved
boddissattva
reviewed
Oct 8, 2021
task-impl/src/main/java/com/chutneytesting/task/amqp/AmqpCleanQueuesTask.java
Show resolved
Hide resolved
boddissattva
reviewed
Oct 8, 2021
task-impl/src/main/java/com/chutneytesting/task/assertion/AssertTask.java
Show resolved
Hide resolved
boddissattva
reviewed
Oct 8, 2021
task-impl/src/main/java/com/chutneytesting/task/assertion/JsonAssertTask.java
Outdated
Show resolved
Hide resolved
task-impl/src/main/java/com/chutneytesting/task/assertion/XmlAssertTask.java
Outdated
Show resolved
Hide resolved
task-impl/src/main/java/com/chutneytesting/task/context/ContextPutTask.java
Show resolved
Hide resolved
task-impl/src/main/java/com/chutneytesting/task/http/HttpDeleteTask.java
Show resolved
Hide resolved
task-impl/src/main/java/com/chutneytesting/task/jms/JmsCleanQueueTask.java
Outdated
Show resolved
Hide resolved
task-impl/src/main/java/com/chutneytesting/task/jms/JmsListenerTask.java
Outdated
Show resolved
Hide resolved
80ab1e9
to
745bdfc
Compare
bessonm
previously approved these changes
Oct 11, 2021
task-impl/src/main/java/com/chutneytesting/task/assertion/XmlAssertTask.java
Outdated
Show resolved
Hide resolved
task-impl/src/main/java/com/chutneytesting/task/jms/JmsCleanQueueTask.java
Show resolved
Hide resolved
8f1ae1e
to
410c5cf
Compare
boddissattva
previously approved these changes
Oct 12, 2021
410c5cf
to
dd3f6a9
Compare
boddissattva
previously approved these changes
Oct 12, 2021
dd3f6a9
to
372ad05
Compare
boddissattva
approved these changes
Oct 12, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue Number
fixes #585
fixes #577
Describe the changes you've made
I have also add target properties to kafka publish task (asked by @iguissouma
Checklist