Skip to content
This repository has been archived by the owner on Feb 23, 2024. It is now read-only.

Task input validators #584

Merged
merged 5 commits into from
Oct 12, 2021
Merged

Task input validators #584

merged 5 commits into from
Oct 12, 2021

Conversation

nbrouand
Copy link
Member

@nbrouand nbrouand commented Oct 8, 2021

Issue Number

fixes #585
fixes #577

Describe the changes you've made

I have also add target properties to kafka publish task (asked by @iguissouma

Checklist

  • Refer to issue(s) the PR solves
  • New java code is covered by tests
  • All new and existing tests pass
  • No git conflict

@nbrouand nbrouand force-pushed the feat/validators branch 2 times, most recently from 57568a4 to a85ac37 Compare October 8, 2021 11:53
@nbrouand nbrouand changed the title Feat/validators Task input validators Oct 8, 2021
@codecov-commenter
Copy link

codecov-commenter commented Oct 8, 2021

Codecov Report

Merging #584 (372ad05) into master (4933f27) will decrease coverage by 0.90%.
The diff coverage is 54.52%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #584      +/-   ##
============================================
- Coverage     74.02%   73.11%   -0.91%     
- Complexity     3405     3410       +5     
============================================
  Files           629      634       +5     
  Lines         14746    14888     +142     
  Branches        864      859       -5     
============================================
- Hits          10915    10886      -29     
- Misses         3386     3560     +174     
+ Partials        445      442       -3     
Impacted Files Coverage Δ
...m/chutneytesting/task/amqp/QpidServerStopTask.java 0.00% <0.00%> (ø)
...tneytesting/task/assertion/JsonValidationTask.java 58.33% <0.00%> (-24.02%) ⬇️
...m/chutneytesting/task/assertion/XmlAssertTask.java 78.84% <0.00%> (-4.83%) ⬇️
...chutneytesting/task/assertion/utils/JsonUtils.java 22.22% <ø> (ø)
...ava/com/chutneytesting/task/context/SleepTask.java 0.00% <0.00%> (ø)
...om/chutneytesting/task/function/JsonFunctions.java 40.00% <ø> (ø)
...ava/com/chutneytesting/task/http/HttpSoapTask.java 0.00% <0.00%> (ø)
...a/com/chutneytesting/task/http/HttpTaskHelper.java 0.00% <0.00%> (ø)
.../chutneytesting/task/http/HttpsServerStopTask.java 0.00% <0.00%> (ø)
...com/chutneytesting/task/jms/JmsBrokerStopTask.java 0.00% <0.00%> (ø)
... and 72 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4933f27...372ad05. Read the comment docs.

@nbrouand nbrouand marked this pull request as ready for review October 11, 2021 13:36
boddissattva
boddissattva previously approved these changes Oct 12, 2021
boddissattva
boddissattva previously approved these changes Oct 12, 2021
@boddissattva boddissattva merged commit 1d16cc2 into master Oct 12, 2021
@boddissattva boddissattva deleted the feat/validators branch October 12, 2021 09:30
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🚀 | Add validation input to task-spi 🚀 | Make json compare as soft assert
4 participants