Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

testing: add an integration test for yaml-test-suite #187

Draft
wants to merge 7 commits into
base: master
Choose a base branch
from

Conversation

tanriol
Copy link

@tanriol tanriol commented Jan 16, 2022

The official YAML test suite (https://github.com/yaml/yaml-test-suite).
Requires the submodule to be checked out.

This is a draft PR because there's quite a number of failures. At the moment I'm seeing 62 unexpected errors (and 19 more errors where yaml-rust Event / Parser / EventReceiver API does not provide enough information about the document). I can mark the other errors as expected errors for now, but want to look at them first to check whether they're yaml-rust errors or some mistakes in this test harness.

@perlpunk
Copy link

perlpunk commented Jan 19, 2022

I would like to mention that I added yaml-rust to the test matrix: https://matrix.yaml.info/ with the help of @tanriol

@tanriol
Copy link
Author

tanriol commented Feb 2, 2022

@chyh1990 / @dtolnay
Sorry for pinging directly, but I've seen no reaction to this PR yet. Should I continue trying to contribute to this repository, or should I instead fork the crate completely and work on improving it in my own fork?

@neithernut
Copy link

neithernut commented Feb 2, 2022

Well, according to @chyh1990's profile, their last activity was on June 3, 2020. But even before that, the activity was rather sparse. PRs and issues just kept accumulating without any meaningful progress for years now.


Maybe there are more active forks already?

@dtolnay
Copy link
Collaborator

dtolnay commented Aug 1, 2022

I am not involved in this crate, since it is no longer used by serde_yaml.

@tanriol
Copy link
Author

tanriol commented Aug 2, 2022

I am not involved in this crate, since it is no longer used by serde_yaml.

Sounds reasonable given the maintenance state of this crate. I'm leaving this PR open just in case, but don't really care about its fate in this case.

@davvid
Copy link

davvid commented Jan 29, 2024

FWIW I have a fork I'm maintaining since I need this to keep working for the long-haul: https://github.com/davvid/yaml-rust/

I'd be happy to take PRs related to this topic there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants