Correctly quote all possible booleans.

[hrach]

Currently, the library incorrectly doesn't add quotes to strings, which will be interpreted as booleans:

yaml-rust/src/emitter.rs

Lines 270 to 271 in bbe0696

	|| string == "true"
	|| string == "false"

Specs describes many other possiblities:
http://yaml.org/type/bool.html

Personally, I encounter this bug with string TRUE in https://github.com/InQuicker/ktmpl/ which produced such value without qutes and kubernetes doesn't accept that value.

[dtolnay]

Thanks for catching this. We would love a PR to fix this!

[ghost]

It would be great if these (previously) valid boolean values ("YES", for example) are always quoted anyway to assure the other side will always decode it as a string. kubectl for example validates the parsed yaml and aborts if booleans are encountered instead of strings.

Leaving them quoted is harmless for version 1.2, and means version 1.1 validations aren't broken unnecessarily.

[hoodie]

@hrach sorry I misread your issue there
does this perhaps do the trick? (#72)

[ghost]

@hoodie For me that would do it perfectly! Once that issue lands, my problem would be solved. For now we solved it by actually changing the consumer code, which luckily was in our reach.

[hrach]

Yes, that seems to be the correct fix. Sorry for writing so unclear issue :-)