Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor tests #77

Open
tenaciousRas opened this issue Sep 29, 2016 · 0 comments
Open

refactor tests #77

tenaciousRas opened this issue Sep 29, 2016 · 0 comments

Comments

@tenaciousRas
Copy link

Expected:
Project is written with testable code that doesn't require integration test that use file-comparison (which is very brittle) to validate regex. For example, in inline.js, isolate all methods that match on regex whenever possible, and unit test them with minimal dependencies that can be injected if necessary.

Actual:
"grunt test" uses integration tests as a way to validate regex matching. This is a poor practice. It's up to you to ask a project contributor how to de-couple the dependencies and write better tests.

versions:

  • affects all versions of this project
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant