Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

submit MyInstagram assignment #1

Open
chzheng opened this issue Dec 7, 2015 · 1 comment
Open

submit MyInstagram assignment #1

chzheng opened this issue Dec 7, 2015 · 1 comment

Comments

@chzheng
Copy link
Owner

chzheng commented Dec 7, 2015

I wish to play more on layouts but was flat out this week.

@codepathreview
Copy link

👍 Good work getting all required stories done. A few notes after checking out the code:

  • Good layout, proper view naming, usage of sp/dp, margin and relative placement rules
  • Good job on a polished UI
  • Consider better organizing your source files
  • Consider including a check to see if internet is available to detect any network failures. Show an appropriate message in case of failure.
  • Consider using the ViewHolder pattern to improve performance of photos ListView.

We have provided a detailed Project 1 Feedback Guide here which covers the most common points we see for this project. Read through the feedback guide point-by-point to determine other ways you could improve your submission. You should consider going back and implementing applicable feedback as well. Keep in mind that one of the most important parts of Android development is learning the correct patterns and conventions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants