Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Accessible Image #45

Closed
3 tasks done
ciampo opened this issue Mar 15, 2020 · 0 comments
Closed
3 tasks done

Accessible Image #45

ciampo opened this issue Mar 15, 2020 · 0 comments
Assignees
@ciampo
Labels
Code P0
Projects
MVP

Comments

@ciampo
Copy link
Owner

ciampo commented Mar 15, 2020 •
edited

  • add responsive sourceset
  • use webp when possible
  • native lazy loading

Sanity docs
Setting Height and Width
@ciampo ciampo self-assigned this Mar 15, 2020
@ciampo ciampo added this to To do in MVP via automation Mar 15, 2020
@ciampo ciampo mentioned this issue Mar 15, 2020
Closed
2 tasks
@ciampo ciampo moved this from To do to In progress in MVP Mar 23, 2020
ciampo added a commit that referenced this issue Mar 30, 2020
@ciampo
GH-45 feat(sanity): get more info for sanity image data
2c50a2f
ciampo added a commit that referenced this issue Mar 30, 2020
@ciampo
GH-45 AccessibleImage srcset/sizes based off responsive config, inclu…
9cc6119 
…ding forceRatio and bg color
ciampo added a commit that referenced this issue Mar 30, 2020
@ciampo
GH-45 allow overriding classname and styles for accessible image
9bda52f
ciampo added a commit that referenced this issue Mar 30, 2020
@ciampo
GH-45 accessible image object-position uses sanity hotspot data
9913ef1
ciampo added a commit that referenced this issue Mar 30, 2020
@ciampo
GH-45 fix AccessibleImage classname overrides
3a184bc
ciampo added a commit that referenced this issue Mar 30, 2020
@ciampo
GH-45 fix hero classnames overrides, make hero full-height
5f32542
@ciampo ciampo closed this as completed Apr 16, 2020
MVP automation moved this from In progress to Done Apr 16, 2020
ciampo added a commit that referenced this issue Apr 16, 2020
@ciampo
GH-45 feat(image): default classname, remove CSS module
52fdb65
ciampo added a commit that referenced this issue Apr 16, 2020
@ciampo
GH-45 feat(image): add tests
3575813
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ciampo ciampo

Labels
Code P0
Projects
No open projects
MVP
  
Done
Milestone
No milestone
Development

No branches or pull requests
1 participant
@ciampo