Merge branch 'github_fixes'

ciaranj · Jun 19, 2012 · debc503 · debc503
2 parents 4f3666d + 56979c0
commit debc503
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 4 deletions.
diff --git a/README.md b/README.md
@@ -53,7 +53,9 @@ Run
 
 Changelog
 =========
-* 0.5.2  
+ * 0.5.3  
+		Fix GitHub strategy to work with v3 of their API (older API versions no longer work!) (Dennis Reimann)
+ * 0.5.2  
 		Allow multiple users per application in Oauth Provider (3 legged) (Evan Prodromou)
 		Improved the behaviour of the OAuth Provider's Form/POST signing behaviours ( Evan Prodromou )
 		Fix broken 3-legged OAuth provider support ( Jason Chu )

diff --git a/lib/auth.strategies/github.js b/lib/auth.strategies/github.js
@@ -55,12 +55,12 @@ module.exports= function(options, server) {
                                          else {
                                            request.session["access_token"]= access_token;
                                            if( refresh_token ) request.session["refresh_token"]= refresh_token;
-                                             my._oAuth.getProtectedResource("https://github.com/api/v2/json/user/show", request.session["access_token"], function (error, data, response) {
+                                             my._oAuth.getProtectedResource("https://api.github.com/user", request.session["access_token"], function (error, data, response) {
                                              if( error ) {
                                                request.getAuthDetails()['github_login_attempt_failed'] = true;
                                                self.fail(callback);
                                              }else {
-                                               self.success(JSON.parse(data).user, callback)
+                                               self.success(JSON.parse(data), callback)
                                              }
                                            })
                                          }

diff --git a/package.json b/package.json
@@ -1,7 +1,7 @@
 {
   "name" : "connect-auth",
   "description" : "Middleware for Connect (node.js) for handling your authentication needs.",
-  "version" : "0.5.2",
+  "version" : "0.5.3",
   "author" : "Ciaran Jessup <ciaranj@gmail.com>",
   "engines" : {"node" : ">=0.6.0"}, 
   "main" : "lib/index.js",