Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

please bump npm package #238

Closed
neofreko opened this issue Jan 29, 2015 · 45 comments
Closed

please bump npm package #238

neofreko opened this issue Jan 29, 2015 · 45 comments

Comments

@neofreko
Copy link

fix for #196 is not in the npm registry yet. All oauth-based passport packages that I've tried these past few days are spewing the same error message:

createCredentials() is deprecated, use tls.createSecureContext instead

Let's save some souls from headache.

Temporary fix is by forking parent package and update oauth dependency to:

"oauth": "git://github.com/ciaranj/node-oauth"

よろしくお願いします!

@r3trosteve
Copy link

Urgh. Clunk. Head hits table.

I'm getting this too. Is there any update?

@VanessaHenderson
Copy link

If you actually look into the code on this repo, auth2.js still uses the createCredentials method. On the 18th Decemeber, 2014 @ciaranj put the line back in that refers to the method.
In the fix #196 that @neofreko mentioned simply removed the line because it was unused. I don't know why it was put back in... I'm guessing it might have been a merge mishap.

@ciaranj
Copy link
Owner

ciaranj commented Feb 18, 2015

Seems reasonable that I screwed up. My life is currently a little upside down dealing with some premature twins :/ sorry, when I get a chance I'll sort it!

@powdahound
Copy link

👍

@lucidtech
Copy link

bump

@monbro
Copy link

monbro commented Mar 6, 2015

+1

1 similar comment
@ohmslaw
Copy link

ohmslaw commented Mar 15, 2015

+1

@kulakowka
Copy link

I have this error too...

@ItalyPaleAle
Copy link

+1

4 similar comments
@basickarl
Copy link

+1

@ghost
Copy link

ghost commented Mar 31, 2015

+1

@joeonmars
Copy link

+1

@GregTurner
Copy link

+1

@balthazar
Copy link

+1

1 similar comment
@mid0111
Copy link

mid0111 commented Apr 11, 2015

👍

@VanessaHenderson
Copy link

@ciaranj think you could bump it soon? Looks like lots of people need it bumped...

@h1f0x
Copy link

h1f0x commented Apr 14, 2015

+1

3 similar comments
@mvach
Copy link

mvach commented Apr 14, 2015

+1

@mhmeadows63
Copy link

+1

@tiddan
Copy link

tiddan commented Apr 16, 2015

+1

@scottsmeester
Copy link

Yo - +1

@MrHaila
Copy link

MrHaila commented Apr 20, 2015

+1

@lgabster
Copy link

me to

@ajitpawar
Copy link

+1

3 similar comments
@danazkari
Copy link

+1

@thessler27
Copy link

+1

@alesscor
Copy link

+1

@DoryZi
Copy link

DoryZi commented Apr 26, 2015

+1

3 similar comments
@jjtortosa
Copy link

+1

@akuz
Copy link

akuz commented Apr 29, 2015

+1

@pshoemaker39
Copy link

+1

@tattivitorino
Copy link

+1 any news on this? can anyone tell me how to fix this? plus, I dont know whether it is related to this warning, but using passport-facebook the profile object comes back undefined!

@kellyrmilligan
Copy link

+1?

@zloyded
Copy link

zloyded commented May 6, 2015

+1

3 similar comments
@aahutsal
Copy link

aahutsal commented May 7, 2015

+1

@ggarber
Copy link

ggarber commented May 7, 2015

+1

@aoberoi
Copy link

aoberoi commented May 7, 2015

👍

@edwardvalentini
Copy link

+1 please

@gabrielbiga
Copy link

#244
This pull request solved for me

@tadman
Copy link

tadman commented May 14, 2015

Would be really nice to see a fix for this merged, especially since there's a solution

@bjackson
Copy link

This project seems abandoned.

@tadman
Copy link

tadman commented May 15, 2015

I'm here because it's used by various Oauth-based back-ends for Passport.

@ciaranj
Copy link
Owner

ciaranj commented May 15, 2015

'Funny' story I finally found a spare moment between feeding ill babies to push a fix (twins are hard) and npm seems knackered:

image

Not really sure how to proceed :/

@ciaranj
Copy link
Owner

ciaranj commented May 15, 2015

huh. weird. It worked anyway!

@ciaranj ciaranj closed this as completed May 15, 2015
@lianyi
Copy link

lianyi commented Sep 2, 2015

+1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests