Fix touch handler synthetic click #228
Conversation
|
Nice edge case! PS: I'm curious about what are you building with SVG |
Yep. Good thing is the
Here it is. The test will fail if the fix is reverted.
Nothing special, it's just an SVG icon inside of the trigger. This one in particular: http://take.ms/TeWjm :) |
Create `nativeTap` helper
| @@ -54,7 +54,7 @@ export function clickTrigger(scope, options = {}) { | |||
| } | |||
|
|
|||
| export function tapTrigger(scope, options = {}) { | |||
| let selector = '.ember-basic-dropdown-trigger'; | |||
| let selector = `.ember-basic-dropdown-trigger ${options.triggerChildSelector || ''}`.trim(); | |||
There was a problem hiding this comment.
Instead of defining this ad-hoc option, you can use the nativeTap function I've just added to trigger a tap in the element inside.
There was a problem hiding this comment.
Rebase over master to get that helper.
…/ember-basic-dropdown into fix-touch-handler-synthetic-click
|
Approved. Let's wait for travis. |
|
Thanks! |
If
e.targetis an SVG elementclick()method doesn't exist. jQuery takes care of that.