Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added labelledby, describedby and required aria properties to the trigger #40

Merged
merged 1 commit into from Jan 24, 2016
Merged

Conversation

ghost
Copy link

@ghost ghost commented Jan 23, 2016

@cibernox
Copy link
Owner

Question: {{basic-dropdown ariaLabelledBy="foobar"}} or {{basic-dropdown aria-labelledBy="foobar"}}?

The second seems closer to the html spec.

@ghost
Copy link
Author

ghost commented Jan 24, 2016

I think ariaLabelledBy, but I don't really have a good reason or anything for it, it just feels more natural.

@cibernox
Copy link
Owner

I, in general, prefer to name things in my components as close as possible to the equivalent html spec, however in this case i've seen that ember has out of the box support for aria-role via the ariaRole property, so let's be consistent with ember here.

cibernox added a commit that referenced this pull request Jan 24, 2016
Added labelledby, describedby and required aria properties to the trigger
@cibernox cibernox merged commit f02d9e5 into cibernox:master Jan 24, 2016
@ghost ghost deleted the add-aria-properties branch January 24, 2016 11:40
@cibernox
Copy link
Owner

Published in 0.8.3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants