Co-locate component templates #661
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR co-locates the component templates with their JS files. This is an important change because without it users cannot easily adopt [first-class component templates](https://github.com/emberjs/rfcs/blob/master/text/0779-first-class-component-templates.md). Co-located templates stay bound to the corresponding class even when you pass the class through arbitrary Javascript. Non-co-located templates don't. Component template co-location is supported in all the ember versions this addon supports. So this should not be a breaking change. Any users who were overriding these templates with their own implementations *would* break, but those users are necessarily relying on private API (the API between each component JS and its own template).
|
I'll merge this and release it as a new major version then. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR co-locates the component templates with their JS files.
This is an important change because without it users cannot easily adopt first-class component templates.
Co-located templates stay bound to the corresponding class even when you pass the class through arbitrary Javascript. Non-co-located templates don't.
Component template co-location is supported in all the ember versions this addon supports. So this should not be a breaking change. Any users who were overriding these templates with their own implementations would break, but those users are necessarily relying on private API (the API between each component JS and its own template).