Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix findCalendarElement #176

Merged
merged 1 commit into from Sep 20, 2018
Merged

Fix findCalendarElement #176

merged 1 commit into from Sep 20, 2018

Conversation

loginovma
Copy link
Contributor

  • Replace 'getContext' with 'find'. It solves the issue when
    a calendar is rendered inside a wormhole.
  • Add example and test for this case to helpers test.

Fix findCalendarElement
787afe6 
- Replace 'getContext' with 'find'. It solves the issue when
  calendar is rendered inside a wormhole.
- Add example and test for this case to helpers test.
@loginovma loginovma mentioned this pull request Sep 19, 2018
Closed
@simonihmig simonihmig mentioned this pull request Sep 20, 2018
Merged
@cibernox
Copy link
Owner

I am kind of surprised that one works and the other doesn't. I thought that find was internally doing getContext().querySelector. If it works for you I'll merge it.

@cibernox cibernox merged commit 20dd2e1 into cibernox:master Sep 20, 2018
@loginovma loginovma deleted the fix-calendar-dropdown branch September 21, 2018 07:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@loginovma @cibernox