Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove ember-native-dom-helpers #34

Closed
wants to merge 1 commit into from
Closed

Remove ember-native-dom-helpers #34

wants to merge 1 commit into from

Conversation

jherdman
Copy link
Contributor

It seems they're not used.

As a sidenote: ember-native-dom-helpers is causing an error to be thrown in an upstream project of mine:

TypeError: checker.exists is not a function

    at Class._emberStringDependencyPresent (/home/vagrant/project/node_modules/ember-native-dom-helpers/node_modules/ember-cli-babel/index.js:372:20)
    at Class._getEmberModulesAPIBlacklist (/home/vagrant/project/node_modules/ember-native-dom-helpers/node_modules/ember-cli-babel/index.js:358:14)
    at Class._getEmberModulesAPIPolyfill (/home/vagrant/project/node_modules/ember-native-dom-helpers/node_modules/ember-cli-babel/index.js:262:30)
    at Class._getBabelOptions (/home/vagrant/project/node_modules/ember-native-dom-helpers/node_modules/ember-cli-babel/index.js:211:12)
    at Class.buildBabelOptions (/home/vagrant/project/node_modules/ember-native-dom-helpers/node_modules/ember-cli-babel/index.js:36:17)
    at Class.transpileTree (/home/vagrant/project/node_modules/ember-native-dom-helpers/node_modules/ember-cli-babel/index.js:52:58)
    at Object.toTree (/home/vagrant/project/node_modules/ember-native-dom-helpers/node_modules/ember-cli-babel/index.js:61:30
    at /home/vagrant/student/node_modules/ember-cli-preprocess-registry/preprocessors.js:180:26
    at Array.forEach (<anonymous>:null:null)
    at processPlugins (/home/vagrant/student/node_modules/ember-cli-preprocess-registry/preprocessors.js:178:11)
    at Function.module.exports.preprocessJs (/home/vagrant/student/node_modules/ember-cli-preprocess-registry/preprocessors.js:171:10)
    at Class.preprocessJs (/home/vagrant/student/node_modules/ember-cli/lib/models/addon.js:1309:25)
    at Class.treeForAddonTestSupport (/home/vagrant/project/node_modules/ember-native-dom-helpers/index.js:20:17)

jherdman added a commit to PrecisionNutrition/date-picker that referenced this pull request Mar 12, 2019
@jherdman
Use ember-power-datepicker Fork
ab4e5b4 
Please see cibernox/ember-power-datepicker#34

We'll be able to cut back to mainline once this is merged and released.
@jherdman
Remove ember-native-dom-helpers
bf2f803 
It seems they're not used.
@jherdman
Copy link
Contributor Author

@cibernox updated, and ready.

@jherdman
Copy link
Contributor Author

Closing. Resolved by 083bb50.

@jherdman jherdman closed this Jul 25, 2019
@jherdman jherdman deleted the remove-native-dom-helpers branch July 25, 2019 14:16
@jherdman jherdman restored the remove-native-dom-helpers branch July 25, 2019 14:16
@jherdman jherdman mentioned this pull request Jul 25, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@jherdman