Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allowClear does not show button when multiple = true #103

Closed
corrspt opened this issue Nov 5, 2015 · 5 comments
Closed

allowClear does not show button when multiple = true #103

corrspt opened this issue Nov 5, 2015 · 5 comments

Comments

@corrspt
Copy link

corrspt commented Nov 5, 2015

Hi,

When I have a power-select with multiple=true and allowClear=true the little cross to remove the items is not shown. If I put multiple=false the cross appears correctly

@cibernox
Copy link
Owner

cibernox commented Nov 5, 2015

The allowClear option only works with single selects. I never thought about making it work with multiple selects since with them the usual thing to do is to remove only on element at a time (or use backspace).

I basically copied select2/selectize and they never provided that option, so neither did I.

@corrspt
Copy link
Author

corrspt commented Nov 5, 2015

I see, from the docs I didn't understand that. (Guess I should make a PR with that added, right :P?)

I guess that's a valid approach. I was thinking when you have several choices and wanted to remove them all, but I guess it's probably not that much of a requirement.

@cibernox
Copy link
Owner

cibernox commented Nov 5, 2015

If you could add a paragraph clarifying that this option only works for single selects that'd be great

@corrspt
Copy link
Author

corrspt commented Nov 5, 2015

I might have some free time tonight, I'll try to help!

@corrspt
Copy link
Author

corrspt commented Nov 5, 2015

I created #105 to help with documentation. I also included the information about allow clear in that PR

@corrspt corrspt closed this as completed Nov 5, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants