Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build error using Clang 5.0.0 #27

Closed
zmertens opened this issue Oct 10, 2017 · 1 comment
Closed

Build error using Clang 5.0.0 #27

zmertens opened this issue Oct 10, 2017 · 1 comment

Comments

@zmertens
Copy link

zmertens commented Oct 10, 2017

I encountered this CMake build error using the following commands:
cmake -G"Ninja" -DCMAKE_CXX_COMPILER=clang++ -DCMAKE_BUILD_TYPE=Release ../..

../../src/ReadProvider.cpp:480:34: error: ordered comparison between pointer and zero ('char *' and 'int')
        while (gzgets(fp, buffer, 1000) > 0 && buffer[0] == '@') {
....
../../utils/paired/interleave-pairs.cpp:62:34: error: ordered comparison between pointer and zero ('char *' and 'int')
        while (gzgets(fp, buffer, 1000) > 0 && buffer[0] == '@') {

I just needed to remove the > 0 comparison to get it to build and compile.
I checked GNU g++ compiler and it works without the change.

@philres
Copy link
Member

philres commented Oct 12, 2017

Thanks for reporting this.

I'll change it with the next release.

philres pushed a commit that referenced this issue Nov 13, 2017
philres pushed a commit that referenced this issue Nov 13, 2017
@philres philres closed this as completed Nov 13, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants