Merge pull request #407 from cicirello/no-fat-jar

Discontinue publishing jar-with-dependencies effective with next release
cicirello · May 15, 2024 · 875c799 · 875c799
2 parents 9cf6b9e + d80d1c5
commit 875c799
Show file tree

Hide file tree

Showing 4 changed files with 6 additions and 46 deletions.
diff --git a/.github/workflows/maven-publish.yml b/.github/workflows/maven-publish.yml
@@ -61,6 +61,5 @@ jobs:
         gh release upload ${TAG} target/${{ env.artifact_name }}-${{ steps.get_version.outputs.VERSION }}.jar
         gh release upload ${TAG} target/${{ env.artifact_name }}-${{ steps.get_version.outputs.VERSION }}-sources.jar
         gh release upload ${TAG} target/${{ env.artifact_name }}-${{ steps.get_version.outputs.VERSION }}-javadoc.jar
-        gh release upload ${TAG} target/${{ env.artifact_name }}-${{ steps.get_version.outputs.VERSION }}-jar-with-dependencies.jar
       env:
         GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -36,12 +36,13 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 * Fixed potential finalizer vulnerability in org.cicirello.sequences.distance.EditDistance, detected by SpotBugs analysis. 
 
 ### Dependencies
-* Bump rho-mu from 3.1.0 to 3.2.0
+* Bump rho-mu from 3.1.0 to 4.0.0
 * Bump org.cicirello:core from 2.5.0 to 2.7.0
 
 ### CI/CD
 * Integrated SpotBugs static analysis into build process.
 * Integrated Find Security Bugs static analysis into build process.
+* Discontinued publication of a `jar-with-dependencies` (BREAKING CHANGE only if you were using the fat jar).
 
 ### Other
 

diff --git a/README.md b/README.md
@@ -154,12 +154,10 @@ and (2) add the following to the repositories section of your pom.xml:
 
 If you don't use a dependency manager that supports importing from Maven Central,
 or if you simply prefer to download manually, prebuilt jars are also attached to 
-each [GitHub Release](https://github.com/cicirello/JavaPermutationTools).
-
-In addition to the regular jar of the library, we also regularly publish a
-`jar-with-dependencies`. The `jar-with-dependencies` does not contain any module 
-declarations (unlike the regular jar file which does). Therefore, the 
-`jar-with-dependencies` should be used on the classpath. 
+each [GitHub Release](https://github.com/cicirello/JavaPermutationTools). If you
+manually download jar files, make sure you also get the relevant versions of the
+dependencies. The simplest way to do this is to import from Maven Central, which
+will obtain the relevant dependencies automatically.
 
 ## License
 

diff --git a/pom.xml b/pom.xml
@@ -300,44 +300,6 @@
 					</includes>
 				</configuration>
 			</plugin>
-			<plugin>
-				<groupId>org.apache.maven.plugins</groupId>
-				<artifactId>maven-shade-plugin</artifactId>
-				<version>3.5.3</version>
-				<configuration>
-					<shadedArtifactAttached>true</shadedArtifactAttached>
-					<shadedClassifierName>jar-with-dependencies</shadedClassifierName>
-					<createDependencyReducedPom>false</createDependencyReducedPom>
-					<filters>
-						<filter>
-							<artifact>*:*</artifact>
-							<excludes>
-								<exclude>module-info.class</exclude>
-							</excludes>
-						</filter>
-						<filter>
-							<artifact>org.cicirello:core</artifact>
-							<excludes>
-								<exclude>META-INF/MANIFEST.MF</exclude>
-							</excludes>
-						</filter>
-						<filter>
-							<artifact>org.cicirello:rho-mu</artifact>
-							<excludes>
-								<exclude>META-INF/MANIFEST.MF</exclude>
-							</excludes>
-						</filter>
-					</filters>
-				</configuration>
-				<executions>
-					<execution>
-						<phase>package</phase>
-						<goals>
-							<goal>shade</goal>
-						</goals>
-					</execution>
-				</executions>
-			</plugin>
 			<plugin>
 				<groupId>com.spotify.fmt</groupId>
 				<artifactId>fmt-maven-plugin</artifactId>