Modified change method of priority queue interfaces and classes to return boolean #54
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cicirello
added this to In progress
in Computational Intelligence Research
via automation
JaCoCo Test Coverage Summary Statistics
|
![sonatype-lift[bot]](https://avatars.githubusercontent.com/in/9843?s=60&v=4){kind=small}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Modified the change method of the PriorityQueue, PriorityQueueDouble, IntPriorityQueue, IntPriorityQueueDouble interfaces, and of the classes that implement them to now return a boolean. This is technically a breaking change, but not going to increment major release number because these interfaces were just introduced, and I believe my own projects are the only ones using this library at the present time, and even those haven't upgraded to the version where these interfaces were introduced. Additionally, it is only a breaking change if someone is implementing the interfaces. If they are simply using the library's implementations, then the change of return type from void to boolean will have no effect on code using the implementations.
Closing Issues
Closes #48
Types of changes