Merge pull request #25 from yrashk/github-webhook-no-timeout

Problem: GitHub PR hook will wait until emitters are done
cicomponents · Jul 23, 2016 · 984c49d · 984c49d
2 parents 59e44db + 182a913
commit 984c49d
Showing 1 changed file with 2 additions and 2 deletions.
diff --git a/cicomponents-github/src/main/java/org/cicomponents/github/impl/GithubPRWebhookServlet.java b/cicomponents-github/src/main/java/org/cicomponents/github/impl/GithubPRWebhookServlet.java
@@ -50,6 +50,8 @@ public class GithubPRWebhookServlet extends HttpServlet implements Servlet {
                 Map<String, Object> payload = new ObjectMapper().readValue(req.getReader(),
                                                                            new TypeReference<Map<String, Object>>() {});
 
+                asyncContext.complete();
+
                 String action = (String) payload.get("action");
                 Integer number = (Integer) payload.get("number");
                 @SuppressWarnings("unchecked")
@@ -65,8 +67,6 @@ public class GithubPRWebhookServlet extends HttpServlet implements Servlet {
                             .forEach(emitter -> emitter.onPullRequestEvent(number));
 
                 }
-
-                asyncContext.complete();
             }
         });
     }