Skip to content
This repository has been archived by the owner on Jan 6, 2022. It is now read-only.

Adds a context menu on right click (on song entries) #221

Merged
merged 1 commit into from Sep 19, 2021

Conversation

SiverDX
Copy link
Contributor

@SiverDX SiverDX commented Sep 19, 2021

Creates the context menu which appears when you click the 'more' button (three dot icon) at the cursor position when you right click on a song

The created context menu belongs to the specific element you right clicked on

'library-track' is used in the titles page
'songs-list-row' seems to be used in the other places

Apple already does it on the artist page

image

(Also is it only me or do comments on the loaded js files cause it to not being able to load them? Only worked after I removed them - got an 'Uncaught SyntaxError: Unexpected end of input' error)

@coredev-uk coredev-uk self-requested a review September 19, 2021 00:11
Copy link
Member

@coredev-uk coredev-uk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After testing it on my end, doesn't appear to work.

@coredev-uk coredev-uk self-requested a review September 19, 2021 00:22
@coredev-uk coredev-uk merged commit 902e515 into ciderapp:master Sep 19, 2021
@coredev-uk
Copy link
Member

Disregard my previous comment, I misunderstood the functionality of this. Thanks.

@coredev-uk coredev-uk removed their request for review September 19, 2021 00:23
@SiverDX SiverDX deleted the add_context_menu branch September 24, 2021 18:27
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants