Change select groups modal loading behaviour #208
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Regardless of whether modal is open or not * Stop updating whenever modal is opened
|
Still need to test runtime improvements with larger dataset than default |
* Also remove stale TODO
|
Rolled back jQuery UI as per https://stackoverflow.com/a/41624770 This resulted in significant performance improvements. Modal opens pretty fast now on dataset with ~1600 groups. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Modal body is generated before the modal is opened, on first launch or whenever the data is updated. Opening the modal does not trigger any changes to the modal body.
Resolves #177