Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Partial Incompatibility with Ember 2.10 #43

Closed
alexlafroscia opened this issue Dec 7, 2016 · 3 comments
Closed

Partial Incompatibility with Ember 2.10 #43

alexlafroscia opened this issue Dec 7, 2016 · 3 comments

Comments

@alexlafroscia
Copy link

@thoov and I came across a case where ember-block-slots is not compatible with Ember 2.10.0. It seems that yielding a set of arguments to a block slot through block-params, when once of those params is a hash, causes the following issue on browsers that do not have a native WeakMap implementation (yeah, it took a while to get to the bottom of this 😉 )

TypeError: Attempting to define property on object that is not extensible.

I created a demo repo here that reproduces the issue. Basically, run the tests in Phantom and you'll see a failure, but in Chrome you will not. Just running ember test will show a message that isn't helpful, an error about an assertion that is just a symptom of the real problem. If you do ember test --serve you'll see both that error, plus an additional message about the "real" one.

Output from ember test

screen shot 2016-12-07 at 2 51 27 pm

Output from ember test --serve

screen shot 2016-12-07 at 3 02 21 pm

@jasonmit
Copy link

jasonmit commented Dec 8, 2016

https://github.com/ciena-blueplanet/ember-block-slots/blob/master/addon/helpers/block-params.js#L27-L31 is likely the cause

Introduced by emberjs/ember.js#14244

jasonmit added a commit to jasonmit/ember-block-slots that referenced this issue Dec 8, 2016
@sglanzer-deprecated
Copy link
Contributor

Awesome root cause analysis and thanks a ton for the PR!

sglanzer-deprecated pushed a commit that referenced this issue Dec 8, 2016
@sglanzer-deprecated
Copy link
Contributor

Closed via #44

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants