Bug: Not Compatible with 2.10 (Glimmer 2) #50
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…dification of isActive
|
Changes Unknown when pulling f4b8b85 on upfluence:am-fix-glimmer-2 into ** on ciena-blueplanet:master**. |
|
Sorry about the delay on this - literally just got my email backlog down to the point where I saw it! |
|
Approved |
|
Approved |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This project uses semver, please check the scope of this pr:
CHANGELOG
Delay the initialization of the
block-slotto thedidInsertElementcallback.Assertion Failed: You modified "isActive" twice on <xxx@component:yield-slot::ember1525> in a single render. It was rendered in "component:yield-slot" and modified in "component:block-slot". This was unreliable and slow in Ember 1.x and is no longer supported. See https://github.com/emberjs/ember.js/issues/13948 for more details.This change is