Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add setting to enforce propTypes on components #118

Merged
merged 3 commits into from
Apr 24, 2017

Conversation

sandersky
Copy link
Contributor

@sandersky sandersky commented Apr 24, 2017

This project uses semver, please check the scope of this pr:

  • #none# - documentation fixes and/or test additions
  • #patch# - backwards-compatible bug fix
  • #minor# - adding functionality in a backwards-compatible manner
  • #major# - incompatible API change

resolves #114

CHANGELOG

  • Added configuration setting that when enabled will enforce that components have the propTypes property defined, even if it is just an empty object.
  • Cleaned up mixin code around processing getDefaultProps() to make it more performant. It now only makes a single setProperties() call instead of one for every getDefaultProps() method in the inheritance/extends chain.
  • Upgraded dependencies.

@coveralls
Copy link

coveralls commented Apr 24, 2017

Coverage Status

Changes Unknown when pulling 6fbd7e2 on sandersky:master into ** on ciena-blueplanet:master**.

5 similar comments
@coveralls
Copy link

Coverage Status

Changes Unknown when pulling 6fbd7e2 on sandersky:master into ** on ciena-blueplanet:master**.

@coveralls
Copy link

Coverage Status

Changes Unknown when pulling 6fbd7e2 on sandersky:master into ** on ciena-blueplanet:master**.

@coveralls
Copy link

Coverage Status

Changes Unknown when pulling 6fbd7e2 on sandersky:master into ** on ciena-blueplanet:master**.

@coveralls
Copy link

Coverage Status

Changes Unknown when pulling 6fbd7e2 on sandersky:master into ** on ciena-blueplanet:master**.

@coveralls
Copy link

Coverage Status

Changes Unknown when pulling 6fbd7e2 on sandersky:master into ** on ciena-blueplanet:master**.

@sandersky
Copy link
Contributor Author

sandersky commented Apr 24, 2017

👍

Approved with PullApprove

@sandersky sandersky merged commit 670eebb into ciena-blueplanet:master Apr 24, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Is there an option to require that propTypes be specified on all components?
3 participants