Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate test helpers to addon-test-support #157

Merged
merged 3 commits into from
Feb 19, 2018
Merged

Migrate test helpers to addon-test-support #157

merged 3 commits into from
Feb 19, 2018

Conversation

juwara0
Copy link
Contributor

@juwara0 juwara0 commented Feb 19, 2018

This project uses semver, please check the scope of this pr:

  • #none# - documentation fixes and/or test additions
  • #patch# - backwards-compatible bug fix
  • #minor# - adding functionality in a backwards-compatible manner
  • #major# - incompatible API change

Closes: https://agile-jira.ciena.com/browse/FROST-926

CHANGELOG

  • Updated test helper to now be provided from addon-test-support. For example, the createComponent test helper previously available at dummy/tests/helpers/ember-prop-types is now available via ember-prop-types/test-support/utils

@juwara0
Copy link
Contributor Author

juwara0 commented Feb 19, 2018

@notmessenger - I am self approving and merging this change.

@juwara0
Copy link
Contributor Author

juwara0 commented Feb 19, 2018 •
edited by cstolli

👍

Approved with PullApprove

@juwara0 juwara0 merged commit 6e21d3c into ciena-blueplanet:master Feb 19, 2018
@juwara0 juwara0 deleted the addonTestSupport branch February 19, 2018 17:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@notmessenger notmessenger Awaiting requested review from notmessenger

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@juwara0