Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update templates and integrate with slack #159

Merged
merged 9 commits into from
Mar 9, 2018

Conversation

juwara0
Copy link
Contributor

@juwara0 juwara0 commented Mar 9, 2018

This project uses semver, please check the scope of this pr:

  • #none# - documentation fixes and/or test additions
  • #patch# - backwards-compatible bug fix
  • #minor# - adding functionality in a backwards-compatible manner
  • #major# - incompatible API change

Closes: https://agile-jira.ciena.com/browse/FROST-1281 and https://agile-jira.ciena.com/browse/FROST-1320

CHANGELOG

  • Updated pull request template
  • Added issue template
  • Updated to pr-bumper version 3
  • Updated to node 8
  • Added slack integration
  • Updated ember-frost-test to ^4.0.1
  • Updated ember-test-utils to ^8.1.1
  • Updated ember-cli-frost-blueprints to ^5.0.2
  • Added package-lock.json file

.travis.yml Outdated
@@ -42,11 +42,13 @@ matrix:

before_install:
- npm config set spin false
- npm install -g coveralls pr-bumper@^1.0.0
- npm install -g bower
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is this necessary when Bower is listed as a devDependency? Are we going to have to add it to other repos too that don't currently have this entry?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The build was failing and I am in the middle of determining if I need to npm install -g bower and do bower install in travis CI or just run bower install

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@notmessenger - Alright, the build is passing now with just running bower install in travis.

@notmessenger
Copy link
Contributor

notmessenger commented Mar 9, 2018

👍

Approved with PullApprove

@juwara0 juwara0 merged commit 5b8cca1 into ciena-blueplanet:master Mar 9, 2018
@juwara0 juwara0 deleted the templatesAndSlack branch March 9, 2018 15:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants