Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove hard-code path to "coverage" folder #97

Closed
notmessenger opened this issue Apr 13, 2017 · 2 comments · Fixed by #107
Closed

Remove hard-code path to "coverage" folder #97

notmessenger opened this issue Apr 13, 2017 · 2 comments · Fixed by #107

Comments

@notmessenger
Copy link
Contributor

In getCurrentCoverage() of _/lib/utils.js

Should instead leverage the ember-cli-code-coverage configuration option values - https://github.com/kategengler/ember-cli-code-coverage#configuration
@job13er
Copy link
Contributor

job13er commented Apr 13, 2017

Maybe as an option, but pr-bumber is used for much more than ember projects, it should not rely on any ember specific configuration.

@job13er
Copy link
Contributor

job13er commented Apr 13, 2017

We can expose a configure option for pr-bumper explicitly, and/or provide an option to use ember-cli-code-coverage configs

This was referenced Jun 16, 2017
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Next major release
2 participants
@job13er @notmessenger