Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move ember-hook from devDependency to dependency #18

Merged
merged 1 commit into from Dec 6, 2017
Merged

Move ember-hook from devDependency to dependency #18

merged 1 commit into from Dec 6, 2017

Conversation

juwara0
Copy link
Contributor

@juwara0 juwara0 commented Dec 6, 2017

This project uses semver, please check the scope of this pr:

  • #none# - documentation fixes and/or test additions
  • #patch# - backwards-compatible bug fix
  • #minor# - adding functionality in a backwards-compatible manner
  • #major# - incompatible API change

CHANGELOG

  • Updated ember-hook to be a dependency instead of a devDependency

@notmessenger
Copy link
Contributor

notmessenger commented Dec 6, 2017 •
edited by dafortin

👍

Approved with PullApprove

@coveralls
Copy link

Coverage Status

Changes Unknown when pulling 1b30767 on juwara0:updateHook into ** on ciena-frost:master**.

@juwara0 juwara0 merged commit 3b60d49 into ciena-frost:master Dec 6, 2017
@juwara0 juwara0 deleted the updateHook branch December 6, 2017 16:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@notmessenger notmessenger Awaiting requested review from notmessenger

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@juwara0 @notmessenger @coveralls