Fix queryForCurrentValue #433
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sophypal
commented
Jun 15, 2017
| @@ -663,7 +667,7 @@ describe('Unit: list-utils', function () { | |||
| valueAttribute: 'secret', | |||
| query: { | |||
| booleanFlag: true, | |||
| universe: '${../universe}' | |||
| universe: '${./universe}' | |||
There was a problem hiding this comment.
${./universe} is correct as the findValue utility in bunsen-core doesn't behave like the path format followed by conditions. Oddly enough, both ../ and ./ will both succeed when the value object is one-level deep.
sophypal
commented
Jun 15, 2017
| @@ -135,7 +135,7 @@ export function getItemsFromAjaxCall ({ajax, bunsenId, data, filter, options, va | |||
| export function getItemsFromEmberData (value, modelDef, data, bunsenId, store, filter) { | |||
| const modelType = modelDef.modelType || 'resources' | |||
| const {labelAttribute, queryForCurrentValue, valueAttribute} = modelDef | |||
| const valueAsId = value[bunsenId] | |||
There was a problem hiding this comment.
I have to believe this was an oversight as most models aren't this flat.
added 3 commits
June 15, 2017 16:08
…picking up newer dependencies with ember-prop-types
|
Changes Unknown when pulling 53c361d on sophypal:fix-mcp-issues into ** on ciena-frost:14.23.x**. |
|
Changes Unknown when pulling 53c361d on sophypal:fix-mcp-issues into ** on ciena-frost:14.23.x**. |
d-ashfield
approved these changes
Jun 16, 2017
|
Changes Unknown when pulling 08f3f74 on sophypal:fix-mcp-issues into ** on ciena-frost:14.23.x**. |
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This project uses semver, please check the scope of this pr:
CHANGELOG
queryForCurrentValueselect option which assumed the id was at the top level of the form's value.