Update to ember-cli@2.12.3 #460

quincyle · 2017-07-26T18:29:35Z

This project uses semver, please check the scope of this pr:

#none# - documentation fixes and/or test additions
#patch# - backwards-compatible bug fix
#minor# - adding functionality in a backwards-compatible manner
#major# - incompatible API change

CHANGELOG

Update to ember-cli@2.12.3

juwara0 · 2017-07-27T17:20:14Z

.travis.yml

@@ -15,11 +15,11 @@ addons:
  firefox: 'latest-esr'
 cache:
  directories:
-  - node_modules
+  - node_module


Should be node_modules

EWhite613 · 2017-07-28T17:05:56Z

Please refer to ciena-frost/ember-frost-core#480 (comment)

coveralls · 2017-07-31T03:15:47Z

Changes Unknown when pulling 0c7dbec on quincyle:master into ** on ciena-frost:master**.

coveralls · 2017-07-31T03:55:25Z

Changes Unknown when pulling 07b1acd on quincyle:master into ** on ciena-frost:master**.

EWhite613 · 2017-07-31T13:57:46Z

Approved

EWhite613 · 2017-07-31T14:11:27Z

tests/unit/components/inputs/select-test.js

-describe('Unit: frost-bunsen-input-select', function () {
+// Quincy Le 2017-07-30
+// can't find injection service:ajax with ember-cli: 2.12.3
+describe.skip('Unit: frost-bunsen-input-select', function () {
  setupComponentTest('frost-bunsen-input-select', {


Change this to

setupComponentTest('frost-bunsen-input-select', { unit: true, needs: ['service:ajax'] })

Then the service will be injected

Already tried it with no luck.

Turns out ember treats 'service:ajax' and 'service: ajax' differently. 'service:ajax' is the correct syntax.

juwara0 · 2017-07-31T16:41:15Z

package.json

    "ember-frost-date-picker": "^7.1.0",
-    "ember-frost-demo-components": "^3.0.1",
+    "ember-frost-demo-components": "git://github.com/helloWorldCindy/ember-frost-demo-components.git#upgrade",


This can be updated to now use the published version 3.1.2

juwara0 · 2017-07-31T16:42:22Z

config/ember-try.js

      bower: {
        dependencies: {
-          'ember': '~2.3.0'
+          'ember': '~2.11.0'


This needs to be the setup for version 2.8

juwara0 · 2017-07-31T16:46:21Z

.travis.yml

 env:
  matrix:
-    - EMBER_TRY_SCENARIO=ember-2-8
-    - EMBER_TRY_SCENARIO=default
+    - EMBER_TRY_SCENARIO=ember-2-11


This needs to be running ember-2-8 instead.

As we've discussed, in the previous version, Bunsen actually never gets run with ember: 2.8 (With ember-source not being set as null in config/ember-try, CI will always run against ember-source presented in package.json, which was ember: ~2.11.0). I tried to run it against ember: 2.8.0, but I'm seeing extra test failure. Since it never runs against 2.8, I won't bother to fix these tests at this moment.

coveralls · 2017-07-31T18:42:37Z

Changes Unknown when pulling 53ba181 on quincyle:master into ** on ciena-frost:master**.

coveralls · 2017-08-02T04:29:58Z

Changes Unknown when pulling f7e1ab7 on quincyle:master into ** on ciena-frost:master**.

quincyle · 2017-08-02T13:48:52Z

package.json

    "ember-cli-chai": "^0.3.2",
    "ember-cli-code-coverage": "0.3.11",
    "ember-cli-dependency-checker": "^1.3.0",
-    "ember-cli-htmlbars-inline-precompile": "0.3.6",
+    "ember-cli-frost-blueprints": "^1.0.0",
+    "ember-cli-htmlbars-inline-precompile": "0.3.12",


Re-run the build that was successful before, with no code change, and got build error from latest ember-cli-htmlbars-inline-precompile that just released. Pin it to 0.3.12 until it gets fixed.

This is most likely related to what is reported here: ciena-frost/ember-frost-core#488

notmessenger · 2017-08-02T17:06:55Z

config/ember-try.js

-        }
-      }
-    },
-    {
      name: 'ember-2-8',


This entry is not correct. Make sure this file is identical to all the other versions of this file used in related upgrades of other repos

We had to do run on ember-2-8 instead of ember-lts-2.8 on this repo because there was a difference between those two releases that was causing failures in the build.

juwara0 · 2017-08-02T17:13:43Z

config/ember-try.js

        },
        resolutions: {
-          'ember': '~2.9.0'
+          'ember': 'lts-2-12'


This can be updated to:

{ name: 'ember-lts-2.12', npm: { devDependencies: { 'ember-source': '~2.12.0' } } },

Missed that one. Thanks for the catch.

Received clarification

juwara0 · 2017-08-02T17:38:51Z

Approved

coveralls · 2017-08-02T18:04:14Z

Changes Unknown when pulling 7e56486 on quincyle:master into ** on ciena-frost:master**.

coveralls · 2017-08-02T18:30:49Z

Changes Unknown when pulling 7e56486 on quincyle:master into ** on ciena-frost:master**.

coveralls · 2017-08-02T19:40:05Z

Changes Unknown when pulling 7e56486 on quincyle:master into ** on ciena-frost:master**.

quincyle added 3 commits July 14, 2017 15:30

upgrate to ember-cli 2.12.3

1a0a2fa

merge with remote.

c023bd8

tmp point demo-component to fork.

57652de

juwara0 added the in progress label Jul 26, 2017

quincyle added 3 commits July 26, 2017 16:49

remove dup deps

e31a019

test build

ea76d95

pin ember try to fix a travis build issue.

8eb0578

juwara0 reviewed Jul 27, 2017

View reviewed changes

EWhite613 mentioned this pull request Jul 28, 2017

Fix ember-try config ciena-frost/ember-frost-core#480

Merged

4 tasks

quincyle added 2 commits July 28, 2017 13:40

fix build

55a79cb

handle deprecation and fix build.

0c7dbec

build aginst ember 2.11 instead of 2.8.

07b1acd

EWhite613 suggested changes Jul 31, 2017

View reviewed changes

juwara0 suggested changes Jul 31, 2017

View reviewed changes

juwara0 reviewed Jul 31, 2017

View reviewed changes

update frost-demo-compnent version && fix skipped tests.

53ba181

quincyle added 3 commits August 1, 2017 22:12

fix test failure on ember 2.8 && let travis runs against ember 2.8

2411a6b

pin ember-cli-htmlbars-inline-precompile to 0.3.12

9ac00ed

fix test in firefox

f7e1ab7

quincyle commented Aug 2, 2017

View reviewed changes

notmessenger previously requested changes Aug 2, 2017

View reviewed changes

juwara0 reviewed Aug 2, 2017

View reviewed changes

juwara0 approved these changes Aug 2, 2017

View reviewed changes

quincyle added 4 commits August 2, 2017 13:25

update ember-try.

ef524ef

fix typo

dfb669e

clean up ember-try

20d59f1

make ember-try correct..

7e56486

EWhite613 approved these changes Aug 2, 2017

View reviewed changes

quincyle merged commit 7eaedc6 into ciena-frost:master Aug 2, 2017

notmessenger mentioned this pull request Dec 20, 2017

Address dependency management issues #491

Closed

63 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update to ember-cli@2.12.3 #460

Update to ember-cli@2.12.3 #460

quincyle commented Jul 26, 2017

juwara0 Jul 27, 2017

EWhite613 commented Jul 28, 2017

coveralls commented Jul 31, 2017

coveralls commented Jul 31, 2017

EWhite613 commented Jul 31, 2017 •

edited by cstolli

Loading

EWhite613 Jul 31, 2017

quincyle Jul 31, 2017

quincyle Jul 31, 2017

juwara0 Jul 31, 2017

juwara0 Jul 31, 2017

juwara0 Jul 31, 2017

quincyle Jul 31, 2017 •

edited

Loading

coveralls commented Jul 31, 2017

coveralls commented Aug 2, 2017

quincyle Aug 2, 2017

juwara0 Aug 9, 2017

notmessenger Aug 2, 2017

juwara0 Aug 2, 2017

juwara0 Aug 2, 2017

quincyle Aug 2, 2017

juwara0 commented Aug 2, 2017 •

edited by cstolli

Loading

coveralls commented Aug 2, 2017

coveralls commented Aug 2, 2017

coveralls commented Aug 2, 2017

Update to ember-cli@2.12.3 #460

Update to ember-cli@2.12.3 #460

Conversation

quincyle commented Jul 26, 2017

This project uses semver, please check the scope of this pr:

CHANGELOG

Choose a reason for hiding this comment

EWhite613 commented Jul 28, 2017

coveralls commented Jul 31, 2017

coveralls commented Jul 31, 2017

EWhite613 commented Jul 31, 2017 • edited by cstolli Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

quincyle Jul 31, 2017 • edited Loading

Choose a reason for hiding this comment

coveralls commented Jul 31, 2017

coveralls commented Aug 2, 2017

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

juwara0 commented Aug 2, 2017 • edited by cstolli Loading

coveralls commented Aug 2, 2017

coveralls commented Aug 2, 2017

coveralls commented Aug 2, 2017

EWhite613 commented Jul 31, 2017 •

edited by cstolli

Loading

quincyle Jul 31, 2017 •

edited

Loading

juwara0 commented Aug 2, 2017 •

edited by cstolli

Loading