Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix error when unsetting model/view #467

Merged
merged 2 commits into from
Sep 13, 2017
Merged

Fix error when unsetting model/view #467

merged 2 commits into from
Sep 13, 2017

Conversation

sophypal
Copy link
Contributor

This project uses semver, please check the scope of this pr:

  • #none# - documentation fixes and/or test additions
  • #patch# - backwards-compatible bug fix
  • #minor# - adding functionality in a backwards-compatible manner
  • #major# - incompatible API change

CHANGELOG

  • Added extra protection around setting of the model/views so that unsetting it after init wouldn't throw an exception.

@notmessenger
Copy link
Contributor

notmessenger commented Sep 13, 2017 •
edited by cstolli
Loading

👍

Approved with PullApprove

@coveralls
Copy link

Coverage Status

Changes Unknown when pulling b5a4f99 on sophypal:integration-fixes into ** on ciena-frost:master**.

@sophypal sophypal merged commit 86f7c7f into ciena-frost:master Sep 13, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@notmessenger notmessenger Awaiting requested review from notmessenger

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@sophypal @notmessenger @coveralls