Add (breaking change) support for optional date pickers #468
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
#MAJOR#
The `date` renderer no longer defaults to the current date, so that we
can present optional fields which do not have a value yet chosen,
without mistakenly persisting today's date as a selection.
### Usage
Default to `undefined`:
```javascript
// bunsen-view.js
{
model: 'foo',
renderer: {
name: 'date'
}
},
```
Default to the current date:
```javascript
// bunsen-view.js
{
model: 'bar',
renderer: {
defaultToCurrentDate: true,
name: 'date'
}
}
```
# Changelog
- Date widget no longer defaults to current date. Specifying
`defaultToCurrentDate: true` in the renderer options will re-enable
this behavior.
- Use ember-frost-date-picker@7.3.0
- Add two different date renderers to demo
TheOtherDude
approved these changes
Sep 13, 2017
sophypal
reviewed
Sep 13, 2017
| @@ -5,6 +5,10 @@ import layout from 'ember-frost-bunsen/templates/components/frost-bunsen-input-d | |||
|
|
|||
| const DATE_FORMAT = 'YYYY-MM-DD' | |||
|
|
|||
| export const deps = { | |||
There was a problem hiding this comment.
Interesting. I see you did this to make it stubbable.
|
👍 |
|
Changes Unknown when pulling 25271bc on gknoy:gknoy/add-optional-date-default into ** on ciena-frost:master**. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This project uses semver, please check the scope of this pr:
Breaking change:
The
daterenderer no longer defaults to the current date, so that we can present optional fields which do not have a value yet chosen, without mistakenly persisting today's date as a selection.One can default to the current date by providing
defaultToCurrentDate: truein the renderer options of the cell config.Usage
Default to
undefined:Default to the current date:
Example (from demo)
Changelog
defaultToCurrentDate: truein the renderer options will re-enable this behavior.