Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix race condition on form schemaLoaded cp and retrigger validation #476

Merged
merged 1 commit into from
Sep 30, 2017
Merged

Fix race condition on form schemaLoaded cp and retrigger validation #476

merged 1 commit into from
Sep 30, 2017

Conversation

sophypal
Copy link
Contributor

This project uses semver, please check the scope of this pr:

  • #none# - documentation fixes and/or test additions
  • #patch# - backwards-compatible bug fix
  • #minor# - adding functionality in a backwards-compatible manner
  • #major# - incompatible API change

CHANGELOG

  • Fixes race condition causing the isSchemaLoaded in the form renderer not to fire during init
  • Fixes validation state that was caused by stale validation data. Calling triggerValidation on the input form's validation handler and when component validators are removed was necessary to sync up the proper validation state.

@coveralls
Copy link

Coverage Status

Changes Unknown when pulling 7de95f0 on sophypal:integration-fixes into ** on ciena-frost:master**.

@sophypal
Copy link
Contributor Author

sophypal commented Sep 30, 2017 •
edited by cstolli
Loading

👍

Approved with PullApprove

@sophypal sophypal merged commit 14ef728 into ciena-frost:master Sep 30, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@sophypal @coveralls