Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed bug when using queryForCurrentValue with multi-selects #502

Conversation

TheOtherDude
Copy link
Contributor

@TheOtherDude TheOtherDude commented Jan 11, 2018

This project uses semver, please check the scope of this pr:

  • #none# - documentation fixes and/or test additions
  • #patch# - backwards-compatible bug fix
  • #minor# - adding functionality in a backwards-compatible manner
  • #major# - incompatible API change

This is a fix for the issue I referenced (and then mysteriously struck out) in this comment: #496 (comment)

I'm not sure why I thought the multi-select worked that way. It could have been related to a recently fixed select dropdown bug (or perhaps just temporary insanity).

CHANGELOG

  • Fixed a bug where multi-select selections were cleared if the selected items were filtered out of the drop down when using queryForCurrentValue
  • Upgraded ember-test-utils NPM devDependency to ^8.1.0
  • Removed package-lock.json until we officially support Node 8

@sophypal
Copy link
Contributor

sophypal commented Jan 11, 2018

👍

Approved with PullApprove

@coveralls
Copy link

Coverage Status

Changes Unknown when pulling c1d7ec2 on TheOtherDude:multi-select-queryForCurrentValue-fix into ** on ciena-frost:master**.

@sophypal
Copy link
Contributor

sophypal commented Jan 11, 2018

👍

Approved with PullApprove

@coveralls
Copy link

Coverage Status

Changes Unknown when pulling 556bc29 on TheOtherDude:multi-select-queryForCurrentValue-fix into ** on ciena-frost:master**.

@TheOtherDude TheOtherDude merged commit 99012ac into ciena-frost:master Jan 11, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants