adding autocomplete support to bunsen #522

helrac · 2018-04-30T20:00:11Z

Overview

Summary

This implemented the autocomplete renderer into bunsen. Autocomplete has also been added into the dummy app.

Closes Add autocomplete support into bunsen #521

Screenshots or recordings

Please provide screenshots or recordings if this PR is modifying the visual UI or UX.

Semver

#none#
#patch#
#minor#
#major#

CHANGELOG

Added autocomplete renderer to bunsen (interchangeable with select)

sophypal · 2018-05-01T00:43:10Z

tests/dummy/app/pods/view/renderers/documentation/autocomplete.md

@@ -0,0 +1,259 @@
+## autocomplete
+
+This renderer provides an autocomplete input which allows one option to be selected.


Expand on he differences between select and autocomplete please.

Also, the rest of the docs is a dup to select. I'd hate to have to maintain 2 separate docs if the implementation for one is altered. Perhaps provide a link and mention that the API is the same as select.

ya, i'll reference select. I didn't like duping it anyways

sophypal · 2018-05-01T00:45:57Z

tests/dummy/app/pods/view/renderers/models/autocomplete.js

+export default {
+  properties: {
+    cookies: {
+      enum: [


Maybe using an enum isn't the best choice for demo. Since you're trying to show that autocomplete is a little different from select. Using an enum the value is validated again the enum. For autocomplete I believe free text is allowed which would fail validation if that text wasn't inenum.

In fact, you might want to provide some protection against using enum for autocomplete. Do you agree?

Well, it's just a different style of dropdown, i see no reason to block using enum. It's up to the end user. The example under examples for autocomplete/autocomplete uses a query. I could switch the examples above to use a query.

It's not just style that's different though. With select you have to choose from the list of available options. With autocomplete you don't have to. This means the value can optionally come from the dropdown list and that behavior breaks the meaning of enum.

So I can understand not wanting to alter the behavior to intentionally block enum but at the very least, lets not encourage people to use it with enum.

yeah, in the documentation I will list what scenario is ideal for autocomplete. IE, wanting the user to type to search for options

sophypal · 2018-05-01T00:50:35Z

addon/components/inputs/autocomplete.js

+     */
+    filterOptions (filter) {
+      const value = this.get('formValue')
+      run.debounce(this, this.runUpdateItems, {value, filter, keepCurrentValue: false}, DEBOUNCE_INTERVAL)


Why does the autocomplete get the debounce but select doesn't?

Well, I didn't want to change the functionality of select, I could give it to select but give it a debounce of 0 unless otherwise specified if you'd like

sophypal

Looks good but some minor concerns with the enum behavior.

sophypal · 2018-05-01T18:30:06Z

addon/components/inputs/select.js

@@ -551,6 +551,7 @@ export default AbstractInput.extend({
     */
    filterOptions (filter) {
      const value = this.get('formValue')
+      console.log('filtering for ' + filter)


juwara0 · 2018-05-02T14:35:19Z

package-lock.json

@@ -952,14 +953,14 @@
    },
    "autoprefixer": {
      "version": "7.2.6",
-      "resolved": "https://registry.npmjs.org/autoprefixer/-/autoprefixer-7.2.6.tgz",
-      "integrity": "sha512-Iq8TRIB+/9eQ8rbGhcP7ct5cYb/3qjNYAR2SnzLCEcwF6rvVOax8+9+fccgXk4bEhQGjOZd5TLhsksmAdsbGqQ==",
+      "resolved": "https://artifactory.ciena.com/api/npm/blueplanet-npm/autoprefixer/-/autoprefixer-7.2.6.tgz?dl=https://registry.npmjs.org/autoprefixer/-/autoprefixer-7.2.6.tgz",


This is incorrect. Since this is a public repo you do not want it to point at artifactory. To fix this you will need to remove the setting in your dev environment that is setting the registery to artifactory for everything and instead place a .npmrc file with that registry setting in your directories for private repos only.

juwara0 · 2018-05-02T14:36:22Z

package.json

@@ -87,7 +87,7 @@
    "ember-cli-svgstore": "github:ciena-blueplanet/ember-cli-svgstore#977df1cf58ae43b1d98a591573c3e06947744321",
    "ember-computed-decorators": "0.3.0",
    "ember-concurrency": "0.7.19",
-    "ember-frost-core": "^8.0.0",
+    "ember-frost-core": "^8.2.2",


This change should be reverted. It is not necessary to update the version of ember-frost-core here since it will already pick up the minor due to the ^ float.

adding autocomplete support to bunsen

a5bb68f

helrac requested review from a team as code owners April 30, 2018 20:00

juwara0 added the in progress label Apr 30, 2018

Heittola added 2 commits April 30, 2018 16:21

fixed linting

e3e3a96

disabling reporter so i can see tests on travis

b873bd4

sophypal reviewed May 1, 2018

View reviewed changes

sophypal requested changes May 1, 2018

View reviewed changes

Heittola added 3 commits May 1, 2018 10:49

updated package files for ember-frost-core

eaf8327

removed the reporter from testem

320c614

PR updates, better documentation, extend select directly, better example

9ee9caf

sophypal reviewed May 1, 2018

View reviewed changes

removed console log

5a2ec51

sophypal previously approved these changes May 1, 2018

View reviewed changes

juwara0 suggested changes May 2, 2018

View reviewed changes

updated package files

6bc87e7

helrac dismissed sophypal’s stale review via 6bc87e7 May 2, 2018 14:47

juwara0 approved these changes May 2, 2018

View reviewed changes

helrac merged commit 56e1916 into ciena-frost:master May 2, 2018

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

adding autocomplete support to bunsen #522

adding autocomplete support to bunsen #522

helrac commented Apr 30, 2018 •

edited

Loading

sophypal May 1, 2018

sophypal May 1, 2018

helrac May 1, 2018

sophypal May 1, 2018

sophypal May 1, 2018

helrac May 1, 2018 •

edited

Loading

sophypal May 1, 2018

helrac May 1, 2018

sophypal May 1, 2018

helrac May 1, 2018 •

edited

Loading

sophypal left a comment

sophypal May 1, 2018

juwara0 May 2, 2018

juwara0 May 2, 2018

		@@ -0,0 +1,259 @@
		## autocomplete

		This renderer provides an autocomplete input which allows one option to be selected.

adding autocomplete support to bunsen #522

adding autocomplete support to bunsen #522

Conversation

helrac commented Apr 30, 2018 • edited Loading

Overview

Summary

Screenshots or recordings

Semver

CHANGELOG

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

helrac May 1, 2018 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

helrac May 1, 2018 • edited Loading

Choose a reason for hiding this comment

sophypal left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

helrac commented Apr 30, 2018 •

edited

Loading

helrac May 1, 2018 •

edited

Loading

helrac May 1, 2018 •

edited

Loading