Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Subscribe to the correct events #538

Merged
merged 3 commits into from
Jul 10, 2018
Merged

Subscribe to the correct events #538

merged 3 commits into from
Jul 10, 2018

Conversation

sophypal
Copy link
Contributor

@sophypal sophypal commented Jul 9, 2018

Overview

Fixes issue #537, select multi-select does not show validation errors

Summary

This PR fixes both renderers by using the correct callbacks exposed by the underlying components for focus.

Issue Number(s)

Which issue(s) does this PR address?

Checklist

  • I have added tests that prove my fix is effective or that my feature works
  • I have evaluated if the README.md documentation needs to be updated
  • I have evaluated if the /tests/dummy/ app needs to be modified
  • I have evaluated if DocBlock headers needed to be added or updated
  • I have verified that lint and tests pass locally with my changes
  • If a fork of a dependent package had to be made to address the issue this PR closes:
    • I noted in the fork's README.md the reason the fork was created
    • I have opened an upstream issue detailing what was deficient about the dependency
    • I have opened an upstream PR addressing this deficiency
    • I have opened an issue in this repository to track this PR and schedule the removal of the usage of the fork

Semver

This project uses semver, please check the scope of this PR:

  • #none#
  • #patch#
  • #minor#
  • #major#

CHANGELOG

@sophypal sophypal requested a review from a team as a code owner July 9, 2018 19:44
@sophypal sophypal requested a review from quincyle July 9, 2018 20:29
quincyle
quincyle previously approved these changes Jul 9, 2018
View reviewed changes
Copy link
Contributor

@quincyle quincyle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Thanks for fixing this.

@notmessenger notmessenger merged commit d40cd44 into ciena-frost:master Jul 10, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@notmessenger notmessenger notmessenger approved these changes

@quincyle quincyle quincyle left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Select renderer does not show validation errors
3 participants
@sophypal @notmessenger @quincyle