Correct state change order #549
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#PATCH#
ember-frost-bunsenwasn't updating the store properly which resulted in the store having an older version of the model.bunsen-core@2.1.1was updated to rely on the store model for validation updates and it causes issues with validation not working correctly on the initial render. Quite a few tests failed with that version ofbunsen-core. This PR fixes the problem by updating the store in the normal fashion (update model/view, update value, then validation). No additional tests were added as current tests assured existing functionality is intact.CHANGELOG
bunsen-core@2.1.1introduced which forced validation with the latest model from the store.