Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix for https://github.com/ciena-frost/ember-frost-file-picker/issues/70 #71

Merged
merged 2 commits into from Jul 18, 2018
Merged

fix for https://github.com/ciena-frost/ember-frost-file-picker/issues/70 #71

merged 2 commits into from Jul 18, 2018

Conversation

iraspopo
Copy link
Contributor

@iraspopo iraspopo commented Jul 18, 2018 •
edited

Overview

Does this PR close an existing issue?

Yes

Summary

See #70

Issue Number(s)

70

Put Closes #XXXX below to auto-close the issue that this PR addresses:

Screenshots or recordings

File selected
screen shot 2018-07-18 at 13 46 18
Subsequent file selection canceled
screen shot 2018-07-18 at 13 46 39
Existing file selection is lost (existing behaviour)
screen shot 2018-07-18 at 13 46 56
Existing file selection is preserved (NEW behaviour)
screen shot 2018-07-18 at 13 46 18

Checklist

  • I have added tests that prove my fix is effective or that my feature works
  • I have evaluated if the README.md documentation needs to be updated
  • I have evaluated if the /tests/dummy/ app needs to be modified
  • I have evaluated if DocBlock headers needed to be added or updated
  • I have verified that lint and tests pass locally with my changes
  • If a fork of a dependent package had to be made to address the issue this PR closes:
    • I noted in the fork's README.md the reason the fork was created
    • I have opened an upstream issue detailing what was deficient about the dependency
    • I have opened an upstream PR addressing this deficiency
    • I have opened an issue in this repository to track this PR and schedule the removal of the usage of the fork

Semver

This project uses semver, please check the scope of this PR:

#patch#

CHANGELOG

  • fix for Cancel selection in file browser causes loss of original file selection

@iraspopo iraspopo requested review from a team as code owners July 18, 2018 17:35
quincyle
quincyle approved these changes Jul 18, 2018
View reviewed changes
Copy link
Contributor

@quincyle quincyle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sophypal sophypal merged commit 01d6083 into ciena-frost:master Jul 18, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@quincyle quincyle quincyle approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Cancel selection in file browser causes loss of original file selection
3 participants
@iraspopo @quincyle @sophypal