Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

switch from block slots to component helper #37

Merged
merged 6 commits into from
Sep 13, 2016

Conversation

srowhani
Copy link
Contributor

@srowhani srowhani commented Sep 12, 2016

major

Demo URL: http://ciena-frost.github.io/ember-frost-info-bar/
Old Version: http://srowhani.github.io/ember-frost-info-bar/

Changelog

  • Switched from block-slots to (component) helper.

@coveralls
Copy link

coveralls commented Sep 12, 2016

Coverage Status

Changes Unknown when pulling 8bb7c66 on srowhani:master into * on ciena-frost:master*.

@sglanzer-deprecated
Copy link
Contributor

Freakin' actions are screwing up all our naming - this is approved (nice work), I just want to spend the evening thinking about the naming before we finalize

@srowhani
Copy link
Contributor Author

screen shot 2016-09-12 at 6 19 58 pm

@coveralls
Copy link

Coverage Status

Changes Unknown when pulling 223bda7 on srowhani:master into * on ciena-frost:master*.

1 similar comment
@coveralls
Copy link

Coverage Status

Changes Unknown when pulling 223bda7 on srowhani:master into * on ciena-frost:master*.

@coveralls
Copy link

Coverage Status

Changes Unknown when pulling db64c3a on srowhani:master into * on ciena-frost:master*.

@sglanzer-deprecated
Copy link
Contributor

A couple notes - the title should just be text - the summary can be either text or a component and right now I'm leaning towards using buttons and links instead of the -module forced on us by actions not being available

I think I can justify this, since links are always supposed to be located to the right of buttons, so we shouldn't need to mix the two sets

@sglanzer-deprecated
Copy link
Contributor

Possibly controls instead of actions on a broader basis, which would make the controls-module something like scopeControls

@sglanzer-deprecated
Copy link
Contributor

Settled on controls - so we can make the middle one scope or scopeControls

@coveralls
Copy link

coveralls commented Sep 13, 2016

Coverage Status

Changes Unknown when pulling 063b467 on srowhani:master into * on ciena-frost:master*.

@coveralls
Copy link

coveralls commented Sep 13, 2016

Coverage Status

Changes Unknown when pulling 063b467 on srowhani:master into * on ciena-frost:master*.

@sglanzer-deprecated
Copy link
Contributor

sglanzer-deprecated commented Sep 13, 2016

Approved - thanks Seena!

Approved with PullApprove

@sglanzer-deprecated sglanzer-deprecated merged commit 2b7206f into ciena-frost:master Sep 13, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants