Merge pull request #110 from srowhani/feature/perf

Performance
ciena-frost · Feb 21, 2017 · b07a972 · b07a972
2 parents 0bb7498 + d2ef900
commit b07a972
Show file tree

Hide file tree

Showing 3 changed files with 14 additions and 23 deletions.
diff --git a/addon/styles/_frost-list-item-container.scss b/addon/styles/_frost-list-item-container.scss
@@ -1,35 +1,21 @@
 .frost-list-item-container {
-  padding: 0 1px 1px;
-  border-top: 1px solid $frost-color-lgrey-1;
+  margin: 1px;
+  outline: 1px solid $frost-color-lgrey-1;
 
   &:hover {
-    & .frost-list-item-container-base,
-    & .frost-list-item-container-expansion {
+    .frost-list-item-container-base,
+    .frost-list-item-container-expansion {
       background-color: $frost-list-item-hover-color;
       cursor: pointer;
     }
   }
 
   &.is-selected {
-    padding: 0;
-    border-right: 1px solid $frost-color-blue-1;
-    border-bottom: 1px solid $frost-color-blue-1;
-    border-left: 1px solid $frost-color-blue-1;
-
-    &.is-lead-selection {
-      border-top: 1px solid $frost-color-blue-1;
-    }
+    position: relative;
+    outline: 1px solid $frost-color-blue-1;
+    z-index: 1;
   }
 
-  &.first {
-    padding-top: 1px;
-    border-top: 0;
-
-    &.is-selected {
-      padding-top: 0;
-      border-top: 1px solid $frost-color-blue-1;
-    }
-  }
 
   // The last list item container is given a class so that it can be targeted
   // This is primarily to support the case where additional bottom margin needs

diff --git a/addon/templates/components/frost-list-content-container.hbs b/addon/templates/components/frost-list-content-container.hbs
@@ -6,6 +6,8 @@
   }}
     {{#each items as |model index|}}
       {{yield model index}}
+    {{else}}
+      {{yield to="inverse"}}
     {{/each}}
   {{/frost-scroll}}
 {{else}}
@@ -36,5 +38,7 @@
     as |model index|
   }}
     {{yield model index}}
+  {{else}}
+    {{yield to="inverse"}}
   {{/vertical-collection}}
 {{/if}}
diff --git a/addon/templates/components/frost-list.hbs b/addon/templates/components/frost-list.hbs
@@ -45,8 +45,7 @@
     frost-list-item-container
     {{if (eq index 0) ' first'}}
     {{if (eq index (sub _items.length 1)) ' last'}}
-    {{if model.isSelected ' is-selected'}}
-    {{if (is-lead-selection _items model) ' is-lead-selection'}}'
+    {{if model.isSelected ' is-selected'}}'
     data-test={{hook (concat hook '-item-container') index=index }}
   >
     <div class='frost-list-item-container-base'>
@@ -87,5 +86,7 @@
       </div>
     {{/if}}
   </div>
+{{else}}
+  {{yield to="inverse"}}
 {{/frost-list-content-container}}
 <div class='frost-list-content-container-bottom-border {{if pagination 'paged'}}'></div>