Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix build in order to publish the previous PR as a minor #104

Merged
merged 6 commits into from
Feb 20, 2017

Conversation

juwara0
Copy link
Contributor

@juwara0 juwara0 commented Feb 17, 2017

This project uses semver, please check the scope of this pr:

  • #patch# - backwards-compatible bug fix
  • #minor# - adding functionality in a backwards-compatible manner
  • #major# - incompatible API change

Closes: #103

CHANGELOG

  • Updated to use latest pr-bumper which supports being able to set a PR to none when publishing a new version is not desired.
  • Publish PR: Comparator functionality #102 which included:
  • Added a default comparator which can be overridden with a custom comparator.
  • Added tests for three scenarios of clicking
  • Modified frost-list template to have a hook at the top of the container for easier testing of items below it.
  • Publish PR Fix issue with Ember 2.11 #105, Fr/optional basic click #106, and Updated Readme again #107, which included:
  • Added optional basicClickDisabled attribute. While basic click is nice, it is not always desirable. If you have a list of 100+ selected items, a mis-click might reset your selections.
  • Fixed issue with Ember 2.11 and run loop
  • Added a default comparator which can be overridden with a custom comparator
  • Added tests for three scenarios of clicking
  • Added an ember hook selector to frost-list-item-container

@juwara0 juwara0 changed the title Create a new patch version in order to publish the previous PR as a minor Fix build in order to publish the previous PR as a minor Feb 17, 2017
@coveralls
Copy link

coveralls commented Feb 17, 2017

Coverage Status

Coverage remained the same at 80.531% when pulling 63cdf8e on juwara0:publishPreviousPR into dd8fef1 on ciena-frost:master.

@frosetti frosetti mentioned this pull request Feb 18, 2017
3 tasks
@TheOtherDude
Copy link
Contributor

Thanks for catching this, Michael. We'll hopefully have it fixed with PR #107.

@juwara0 juwara0 reopened this Feb 20, 2017
@coveralls
Copy link

coveralls commented Feb 20, 2017

Coverage Status

Coverage increased (+0.8%) to 81.356% when pulling 63cdf8e on juwara0:publishPreviousPR into dd8fef1 on ciena-frost:master.

@coveralls
Copy link

coveralls commented Feb 20, 2017

Coverage Status

Coverage remained the same at 81.356% when pulling ad57892 on juwara0:publishPreviousPR into ebc5810 on ciena-frost:master.

@juwara0
Copy link
Contributor Author

juwara0 commented Feb 20, 2017

👍

Approved with PullApprove

@juwara0 juwara0 merged commit c64de8b into ciena-frost:master Feb 20, 2017
@juwara0 juwara0 mentioned this pull request Feb 20, 2017
4 tasks
@juwara0 juwara0 deleted the publishPreviousPR branch February 20, 2017 15:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

pr-bumper never published a new minor for PR 102
3 participants