Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fr/shift select comparator #111

Merged
merged 2 commits into from
Feb 26, 2017
Merged

Fr/shift select comparator #111

merged 2 commits into from
Feb 26, 2017

Conversation

frosetti
Copy link
Contributor

This project uses semver, please check the scope of this pr:

  • #none# - documentation fixes and/or test additions
  • #patch# - backwards-compatible bug fix
  • #minor# - adding functionality in a backwards-compatible manner
  • #major# - incompatible API change

CHANGELOG

  • Removed basicClickDisabled as it was never an agreed upon UX change.
  • Fixed non default itemComparator failing on shift based clicks.

@coveralls
Copy link

coveralls commented Feb 24, 2017

Coverage Status

Changes Unknown when pulling 9fa2ee2 on frosetti:fr/shift_select_comparator into ** on ciena-frost:master**.

1 similar comment
@coveralls
Copy link

Coverage Status

Changes Unknown when pulling 9fa2ee2 on frosetti:fr/shift_select_comparator into ** on ciena-frost:master**.

@TheOtherDude
Copy link
Contributor

👍

@TheOtherDude TheOtherDude merged commit 8ab5b8d into ciena-frost:master Feb 26, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants