Publish updates to gh-pages fix #120
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Changes Unknown when pulling b7b8191 on juwara0:publishUpdates into ** on ciena-frost:master**. |
|
👍 |
job13er
reviewed
Mar 4, 2017
|
|
||
| after_success: | ||
| - $(npm root -g)/pr-bumper/.travis/maybe-publish-coverage.sh | ||
| - .travis/maybe-publish-coverage.sh | ||
| - .travis/maybe-publish-gh-pages.sh |
There was a problem hiding this comment.
I'm surprised this works. I thought it would have to be in script or otherwise before the version bump. Are you not checking for the bump commit in maybe-publish-gh-pages.sh?
|
|
||
| if isBumpCommit | ||
| then | ||
| echo "Skipping gh-pages publish for version bump commit" |
There was a problem hiding this comment.
I would think, with this being called in after_success after the version is bumped, this would always enter here and skip the publish.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This project uses semver, please check the scope of this pr:
Closes: #119
CHANGELOG