Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable test regression validation #133

Merged
merged 4 commits into from
May 2, 2017

Conversation

juwara0
Copy link
Contributor

@juwara0 juwara0 commented May 2, 2017

This project uses semver, please check the scope of this pr:

  • #none# - documentation fixes and/or test additions
  • #patch# - backwards-compatible bug fix
  • #minor# - adding functionality in a backwards-compatible manner
  • #major# - incompatible API change

CHANGELOG

  • Added test regression validation

@juwara0 juwara0 changed the title Enable validation Enable test regression validation May 2, 2017
@coveralls
Copy link

Coverage Status

Coverage remained the same at 91.852% when pulling cdec807 on juwara0:enableValidation into d03b8fe on ciena-frost:master.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 91.852% when pulling 6af86e5 on juwara0:enableValidation into d03b8fe on ciena-frost:master.

package.json Outdated
@@ -9,6 +9,7 @@
},
"scripts": {
"build": "ember build",
"coverage": "pr-bumper check-coverage",
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I find this a little misleading. npm run coverage sounds like you're running coverage, not checking it.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I updated this command to check-coverage

@job13er
Copy link

job13er commented May 2, 2017

Approved

Approved with PullApprove

@coveralls
Copy link

Coverage Status

Coverage remained the same at 91.852% when pulling a4a004c on juwara0:enableValidation into d03b8fe on ciena-frost:master.

@juwara0
Copy link
Contributor Author

juwara0 commented May 2, 2017

👍

Approved with PullApprove

@juwara0 juwara0 merged commit b70e645 into ciena-frost:master May 2, 2017
@juwara0 juwara0 deleted the enableValidation branch May 2, 2017 22:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants