Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove custom floor helper #150

Closed
wants to merge 2 commits into from

Conversation

jscharf
Copy link

@jscharf jscharf commented Oct 19, 2017

This project uses semver, please check the scope of this pr:

  • #none# - documentation fixes and/or test additions
  • #patch# - backwards-compatible bug fix
  • #minor# - adding functionality in a backwards-compatible manner
  • #major# - incompatible API change

Notes

This project has ember-math-helpers as a dependency so a custom floor helper is no longer needed. As far as I can tell, it's only used in one place anyway, which is in the pagination template for the last page button. I tested the pagination buttons after removing these files and it still works.

Resolves #84

CHANGELOG

  • Remove custom floor helper

@coveralls
Copy link

Coverage Status

Changes Unknown when pulling 2b66851 on jscharf:remove-floor-helper into ** on ciena-frost:master**.

@notmessenger
Copy link
Contributor

References to floor need to be removed from tests/unit/helpers/is-lead-selection.js

@notmessenger
Copy link
Contributor

notmessenger commented Oct 20, 2017

This PR needs to be a major, not a patch. This is due to the fact that we were exporting this floor helper at the ember-frost-list/helpers/floor namespace and do not know what other consuming code may still be importing it, regardless of whether we have quit consuming it internally in this add-on.

I have made this change.

Update your changelog entry to reflect the removal of this previously-exported helper

@jscharf jscharf closed this Nov 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Replace the floor helper with ember-math-helpers
3 participants